KEMBAR78
Make context-propagation-api dependency optional + documentation by simonbasle · Pull Request #3100 · reactor/reactor-core · GitHub
Skip to content

Make context-propagation-api dependency optional + documentation #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2022
Merged

Make context-propagation-api dependency optional + documentation #3100

merged 2 commits into from
Jul 1, 2022

Conversation

@simonbasle
Copy link
Contributor

@simonbasle simonbasle commented Jul 1, 2022 •
edited
Loading

Polishing of #3098 :

  • make dependency optional
  • mention the optional SPI in the accessor's javadoc

@simonbasle simonbasle added the type/chores A task not related to code (build, formatting, process, ...) label Jul 1, 2022
@simonbasle simonbasle added this to the 3.5.0-M4 milestone Jul 1, 2022
@simonbasle
Copy link
Contributor Author

Should we add a quick mention of context-propagation support in the reference guide ?

@simonbasle simonbasle marked this pull request as ready for review July 1, 2022 08:32
@simonbasle simonbasle requested a review from a team as a code owner July 1, 2022 08:32
@simonbasle
Copy link
Contributor Author

@rstoyanchev @chemicL thanks for the review. I've added a small paragraph about context-propagation support in the reference guide as well, see last commit

@simonbasle simonbasle requested review from chemicL and rstoyanchev July 1, 2022 09:09
@simonbasle simonbasle changed the title Make context-propagation dependency optional Make context-propagation-api dependency optional + documentation Jul 1, 2022
@simonbasle simonbasle merged commit 35f49d5 into main Jul 1, 2022
@simonbasle simonbasle deleted the contextPropagationOptional branch July 1, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@violetagg violetagg violetagg approved these changes

@chemicL chemicL chemicL approved these changes

@rstoyanchev rstoyanchev Awaiting requested review from rstoyanchev

Assignees

No one assigned

Labels

type/chores A task not related to code (build, formatting, process, ...)

Projects

None yet

Milestone

3.5.0-M4

Development

Successfully merging this pull request may close these issues.

4 participants

@simonbasle @rstoyanchev @violetagg @chemicL