KEMBAR78
Use Type->getIterableValueType() over ArrayType->getItemType() by staabm · Pull Request #6479 · rectorphp/rector-src · GitHub
Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Nov 23, 2024

less risky first step which does not involve changing instanceof *Type checks.

relying on Type-interface will ease using Type instead of deprecated instanceof *Type conditions

@staabm staabm marked this pull request as ready for review November 23, 2024 09:16
@samsonasik
Copy link
Member

@staabm ok, let's give it a try ;), thank you

@samsonasik samsonasik merged commit 391ba2a into rectorphp:main Nov 23, 2024
36 checks passed
@staabm staabm deleted the fix4 branch November 23, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants