KEMBAR78
Update developing with docker: Fix php version to 8.2. by uncaught · Pull Request #6490 · rectorphp/rector-src · GitHub
Skip to content

Update developing with docker: Fix php version to 8.2. #6490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2024
Merged

Update developing with docker: Fix php version to 8.2. #6490

merged 1 commit into from
Nov 23, 2024

Conversation

@uncaught
Copy link
Contributor

  • With PHP 8.2 being the development environment, I've set the Dockerfile to reflect that version. Otherwise we'd already get 8.4.
  • I've removed the deprecated version key from the docker-compose.yml
  • The other changes came from a run of docker compose run --rm php composer fix-cs - curious why the main branch had those dirty bits.

@samsonasik samsonasik merged commit 0d1dbd7 into rectorphp:main Nov 23, 2024
36 checks passed
@samsonasik
Copy link
Member

Thank you @uncaught

@uncaught uncaught deleted the update_docker branch November 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uncaught @samsonasik