KEMBAR78
[TypeDeclaration] Skip with default value and assigned mixed on TypedPropertyFromAssignsRector by samsonasik · Pull Request #6514 · rectorphp/rector-src · GitHub
Skip to content

[TypeDeclaration] Skip with default value and assigned mixed on TypedPropertyFromAssignsRector #6514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2024
Merged

[TypeDeclaration] Skip with default value and assigned mixed on TypedPropertyFromAssignsRector #6514

merged 2 commits into from
Nov 26, 2024

Conversation

@samsonasik
Copy link
Member

The following code should be skipped, as assign mixed can be anything:

final class SkipDefaultTypeMixed
{
    private $property = true;

    public function run($prop)
    {
        $this->property = $prop;
    }
}

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit eb3f32d into main Nov 26, 2024
36 checks passed
@samsonasik samsonasik deleted the skip-default-type-mixed branch November 26, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samsonasik