[Attributes] Cover slash newline in AnnotationToAttributeRector with values #6557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-behat-attr
branch
from
acc55c5 to
7e7f1e2
Compare
TomasVotruba
force-pushed
the
tv-behat-attr
branch
from
7e7f1e2 to
18c7c3b
Compare
samsonasik
reviewed
Dec 11, 2024
| // special case for newline | ||
| $docValue = (string) $docNode->value; | ||
| if (str_contains($docValue, '\\')) { | ||
| $docValue = Strings::replace($docValue, "#\\\\\n#", ''); |
There was a problem hiding this comment.
"\r?\n" should be used to support windows newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.