KEMBAR78
Add `esc-to-deselect-line` feature by fregante · Pull Request #1878 · refined-github/refined-github · GitHub
Skip to content

Add esc-to-deselect-line feature #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 25, 2019
Merged

Add esc-to-deselect-line feature #1878

merged 5 commits into from
Mar 25, 2019

Conversation

@fregante
Copy link
Member

@fregante fregante commented Mar 22, 2019 •
edited
Loading

@sindresorhus
Copy link
Member

Shouldn't it work on PR diffs too?

Example: https://github.com/sindresorhus/refined-github/pull/1878/files#diff-7bb46402a79dd0637618b43751bcc733R66

@fregante
Copy link
Member Author

fregante commented Mar 24, 2019 •
edited
Loading

Indeed. Currently it only checks for #L but that is #diff-, which is not necessarily just a line selection, but it could also be a file selection.

@sindresorhus
Copy link
Member

sindresorhus commented Mar 24, 2019 •
edited
Loading

You can detect it though. Notice how line selections end in R23 where 23 is the line number, while file selections don't.

@fregante fregante merged commit f26911b into master Mar 25, 2019
@sindresorhus sindresorhus deleted the deselect-line branch March 25, 2019 04:44
@fregante fregante mentioned this pull request Mar 30, 2019
Closed
@tomirons
Copy link

This doesn't work on Chrome for MacOS 74.0.3729.169. I tried viewing a commit and a specific file, neither of them worked.

Any tips for Mac users?

@fregante
Copy link
Member Author

fregante commented May 30, 2019 •
edited
Loading

It works for me in Firefox and Chrome.

  1. Visit this
  2. Press ESC
  3. Notice the 2 selected lines becoming unselected

@tomirons
Copy link

Unfortunately that still doesn't work. I even tried key combinations like cmd + esc, option + esc, control + esc, and fn + esc.

@afolarin
Copy link

Esc not working for me on Chrome
Google Chrome 78.0.3904.70 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees

No one assigned

Labels

enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unselect selected lines on files or commits

4 participants

@fregante @sindresorhus @tomirons @afolarin