Merge pull request #12102 from koic/fix_an_error_for_style_lambda_call

koic · web-flow · commit 235f7491c065 · 2023-08-09T00:09:03.000+09:00
Fix an error for `Style/LambdaCall`
diff --git a/changelog/fix_an_error_for_style_lambda_call.md b/changelog/fix_an_error_for_style_lambda_call.md
@@ -0,0 +1 @@
+* [#12102](https://github.com/rubocop/rubocop/pull/12102): Fix an error for `Style/LambdaCall` when using nested lambda call `x.().()`. ([@koic][])
diff --git a/lib/rubocop/cop/style/lambda_call.rb b/lib/rubocop/cop/style/lambda_call.rb
@@ -20,6 +20,7 @@ module Style
       #  lambda.(x, y)
       class LambdaCall < Base
         include ConfigurableEnforcedStyle
+        include IgnoredNode
         extend AutoCorrector
 
         MSG = 'Prefer the use of `%<prefer>s` over `%<current>s`.'
@@ -33,8 +34,12 @@ def on_send(node)
             current = node.source
 
             add_offense(node, message: format(MSG, prefer: prefer, current: current)) do |corrector|
+              next if part_of_ignored_node?(node)
+
               opposite_style_detected
               corrector.replace(node, prefer)
+
+              ignore_node(node)
             end
           else
             correct_style_detected
diff --git a/spec/rubocop/cop/style/lambda_call_spec.rb b/spec/rubocop/cop/style/lambda_call_spec.rb
@@ -15,6 +15,18 @@
       RUBY
     end
 
+    it 'registers an offense for x.().()' do
+      expect_offense(<<~RUBY)
+        x.(a, b).(c)
+        ^^^^^^^^^^^^ Prefer the use of `x.(a, b).call(c)` over `x.(a, b).(c)`.
+        ^^^^^^^^ Prefer the use of `x.call(a, b)` over `x.(a, b)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        x.(a, b).call(c)
+      RUBY
+    end
+
     it 'registers an offense for correct + opposite' do
       expect_offense(<<~RUBY)
         x.call(a, b)
