Fix Gemspec/DevelopmentDependencies not trigger when add_development_dependency has more then one arguments

Bhacaz · Bhacaz · commit e768851a1480 · 2023-05-12T13:27:03.000-04:00
diff --git a/changelog/fix_gemspec_development_dependencies_not_trigger.md b/changelog/fix_gemspec_development_dependencies_not_trigger.md
@@ -0,0 +1 @@
+* [#11872](https://github.com/rubocop/rubocop/pull/11872): Fix `Gemspec/DevelopmentDependencies` not trigger when add_development_dependency has more then one arguments. ([@Bhacaz][])
diff --git a/lib/rubocop/cop/gemspec/development_dependencies.rb b/lib/rubocop/cop/gemspec/development_dependencies.rb
@@ -75,7 +75,7 @@ class DevelopmentDependencies < Base
 
         # @!method add_development_dependency?(node)
         def_node_matcher :add_development_dependency?, <<~PATTERN
-          (send _ :add_development_dependency (str #forbidden_gem? ...))
+          (send _ :add_development_dependency (str #forbidden_gem? ...) _? _?)
         PATTERN
 
         # @!method gem?(node)
diff --git a/spec/rubocop/cop/gemspec/development_dependencies_spec.rb b/spec/rubocop/cop/gemspec/development_dependencies_spec.rb
@@ -23,6 +23,28 @@
       RUBY
     end
 
+    it 'registers an offense when using `#add_development_dependency` in a gemspec a single version argument' do
+      expect_offense(<<~RUBY, 'example.gemspec', preferred_file: enforced_style)
+        Gem::Specification.new do |spec|
+          spec.name = 'example'
+          spec.add_development_dependency 'foo', '>= 1.0'
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Specify development dependencies in %{preferred_file}.
+          spec.add_development_dependency 'allowed', '>= 1.0'
+        end
+      RUBY
+    end
+
+    it 'registers an offense when using `#add_development_dependency` in a gemspec with two version' do
+      expect_offense(<<~RUBY, 'example.gemspec', preferred_file: enforced_style)
+        Gem::Specification.new do |spec|
+          spec.name = 'example'
+          spec.add_development_dependency 'foo', '>= 1.0', '< 2.0'
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Specify development dependencies in %{preferred_file}.
+          spec.add_development_dependency 'allowed', '>= 1.0', '< 2.0'
+        end
+      RUBY
+    end
+
     it 'registers no offenses when specifying dependencies in Gemfile' do
       expect_no_offenses(<<~RUBY, 'Gemfile')
         gem 'example'
