Prevent --display-time CLI option from invalidating cache #14479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovro-bikic
commented
Aug 26, 2025
| # @api private | ||
| class ResultCache | ||
| NON_CHANGING = %i[color format formatters out debug fail_level | ||
| NON_CHANGING = %i[color format formatters out debug display_time fail_level |
There was a problem hiding this comment.
No new specs because not all other non-changing options have been tested either, only a small set.
|
Can you add a changelog entry? |
lovro-bikic
force-pushed
the
display-time-shouldnt-impact-cache
branch
from
5535443 to
5849328
Compare
lovro-bikic
force-pushed
the
display-time-shouldnt-impact-cache
branch
from
5849328 to
d500cc9
Compare
Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running RuboCop with
--display-timeoption will invalidate cache. This PR disables the option from affecting cache.