Fix false positives for Lint/DuplicateMethods when the self-alias trick is used
#14300
Conversation
viralpraxis
force-pushed
the
fix-lint-duplicate-methods-false-positives-with-self-aliases
branch
from
197fcf2 to
9ecaf38
Compare
|
I've never heard of this trick, but if it's something common probably the cop's docs should also be expanded to mention explicitly that we're allowing this and why. |
viralpraxis
force-pushed
the
fix-lint-duplicate-methods-false-positives-with-self-aliases
branch
from
9ecaf38 to
e605184
Compare
Done. You can learn a bit more here: https://bugs.ruby-lang.org/issues/13574 |
|
Note to self - an explanation of the need for this https://bugs.ruby-lang.org/issues/13574 Seems it's a bit controversial, so I wonder if this should be behind a flag. My main concern is that you might want to suppress the warnings or you might have made a mistake in your alias and it's kind of hard to guess. |
|
@rubocop/rubocop-core Any opinions about this suggestion? |
|
It seems fine to me. It's sad that it needs such an unintuitive workaround (I also don't think that it is documented anywhere) but I also have encountered such code in different places to achieve the same thing. At least with rails you have access to a descriptive name for it, wish ruby would do something like that too. Personally I find it very unlikely to write code like this by accident and not fix it if you intended to do a "real" alias. If you expect some method to be available after, you should notice pretty quickly that it actually isn't. |
viralpraxis
force-pushed
the
fix-lint-duplicate-methods-false-positives-with-self-aliases
branch
from
e605184 to
b275d5d
Compare
viralpraxis
force-pushed
the
fix-lint-duplicate-methods-false-positives-with-self-aliases
branch
2 times, most recently
from
c14a846 to
26e388d
Compare
…ck is used When there's a self alias, there's no need to register an offense: ```ruby class a alias foo foo # or alias_method :foo, :foo def foo; end ``` Using the alias-self trick indicates that developer is trying to avoid "method redefinition" warning.
viralpraxis
force-pushed
the
fix-lint-duplicate-methods-false-positives-with-self-aliases
branch
from
26e388d to
a8e6ef9
Compare
3 participants
When there's a self-alias, there's no need to register an offense:
Using the alias-self trick indicates that developer is trying to avoid "method redefinition" warning.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.