Enhance Naming/MethodName cop to detect offenses within define_method calls
#14331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, update the cop examples in the docs as well. Apart from this your changes look good to me. |
…hod` calls ref: rubocop#14325 (comment) This patch enhances `Naming/MethodName` to detect these offenses: ```ruby define_method(:fooBar) {} # offense if style is `snake_case` define_method(:foo_bar) {} # offense if style is `camelCase` ```
viralpraxis
force-pushed
the
enhance-naming-method-name-cop-to-detect-offenses-within-define-method-calls
branch
from
51370b0 to
04cc28a
Compare
Done! |
|
CI failure is unrelated and seems to be already fixed here: ruby/rubygems@9a9d0e4 |
bbatsov
approved these changes
Jun 26, 2025
|
Thanks! |
viralpraxis
deleted the
enhance-naming-method-name-cop-to-detect-offenses-within-define-method-calls
branch
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #14325 (comment)
This patch enhances
Naming/MethodNameto detect these offenses:Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.