[Fix #11782] Move pending cops warning out of ConfigLoader #14341
+136
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `RuboCop::ConfigLoader` emitted pending cops warnings as a side effect of loading configuration files. This caused unintended stdout output during tests and could interfere with CLI operations like `--auto-gen-config`. This patch moves the responsibility for pending cops reporting to a dedicated `PendingCopsReporter` class. The CLI now explicitly invokes the reporter after loading configuration, ensuring that `ConfigLoader` remains a pure loader without user-facing output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11782
Previously,
RuboCop::ConfigLoaderemitted pending cops warnings as a side effect of loading configuration files. This caused unintended stdout output during tests and could interfere with CLI operations like--auto-gen-config.This patch moves the responsibility for pending cops reporting to a dedicated
PendingCopsReporterclass. The CLI now explicitly invokes the reporter after loading configuration, ensuring thatConfigLoaderremains a pure loader without user-facing output.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.