-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix incorrect autocorrect for Style/AccessModifierDeclarations #14354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
093ad5e to
6586212
Compare
6586212 to
1e2d281
Compare
| @@ -0,0 +1 @@ | |||
| * [#14354](https://github.com/rubocop/rubocop/pull/14354): Fix incorrect autocorrect for `Style/AccessModifierDeclarations`. ([@girasquid][]) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a bit more context? e.g.,
| * [#14354](https://github.com/rubocop/rubocop/pull/14354): Fix incorrect autocorrect for `Style/AccessModifierDeclarations`. ([@girasquid][]) | |
| * [#14354](https://github.com/rubocop/rubocop/pull/14354): Fix incorrect autocorrect for `Style/AccessModifierDeclarations` when using a grouped access modifier declaration. ([@girasquid][]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done 👍🏻
| RUBY | ||
| end | ||
|
|
||
| it 'does not delete methods before the group declaration' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update it? The description in it should only state the condition under which an offense is registered.
| it 'does not delete methods before the group declaration' do | |
| it 'registers an offense when using a grouped access modifier declaration' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great improvement, I couldn't figure out what to describe this with - thanks for the suggestion, done 👍🏻
1e2d281 to
fe4196d
Compare
…sing a grouped access modifier declaration.
fe4196d to
1cfebee
Compare
|
Thanks! |
I noticed that when running autocorrect for
Style/AccessModifierDeclarations, the method above the group declaration was being deleted. So this:After going through autocorrect would become:
This PR adds a spec demonstrating the behavior with as small a code sample as I could get down to, and then fixes the issue - when trying to change the code it was always using index
1, which wasn't correct if the AST had the entire class body for what needed to be processed.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.