KEMBAR78
Add `tsort` to runtime dependency by koic · Pull Request #14358 · rubocop/rubocop · GitHub
Skip to content

Conversation

koic
Copy link
Member

@koic koic commented Jul 12, 2025

This PR fixes the following build error in the Ruby 3.5 build matrix:

$ bundle exec rake spec
(snip)

==> Failures

  1) RuboCop Project requiring all of `lib` with verbose warnings enabled emits no warnings
     Failure/Error: expect(warnings).to eq []

       expected: []
            got: ["/home/runner/work/rubocop/rubocop/lib/rubocop/cop/style/parallel_assignment.rb:3:
                  warning: tsort wa...om the standard library, but will no longer be part of
                  the default gems starting from Ruby 3.6.0\n"]

https://github.com/rubocop/rubocop/actions/runs/16236943172/job/45848342320

Please see for more details:


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following build error in the Ruby 3.5 build matrix:

```console
$ bundle exec rake spec
(snip)

==> Failures

  1) RuboCop Project requiring all of `lib` with verbose warnings enabled emits no warnings
     Failure/Error: expect(warnings).to eq []

       expected: []
            got: ["/home/runner/work/rubocop/rubocop/lib/rubocop/cop/style/parallel_assignment.rb:3:
                  warning: tsort wa...om the standard library, but will no longer be part of
                  the default gems starting from Ruby 3.6.0\n"]
```

https://github.com/rubocop/rubocop/actions/runs/16236943172/job/45848342320

Please see for more details:

- https://bugs.ruby-lang.org/issues/21442
- ruby/ruby#13841
@koic koic force-pushed the add_tsort_to_runtime_dependency branch from 86d774d to 30d37f5 Compare July 12, 2025 11:13
@koic koic merged commit 0d2dd87 into rubocop:master Jul 12, 2025
24 checks passed
@koic koic deleted the add_tsort_to_runtime_dependency branch July 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant