KEMBAR78
[Fix #14322] Expand the scope of `Style/ItAssignment` to consider all local variable and method parameter names by dvandersluis · Pull Request #14365 · rubocop/rubocop · GitHub
Skip to content

Conversation

@dvandersluis
Copy link
Member

Expands Style/ItAssignment to register offenses for all local variable assignment and method parameters named it.

Fixes #14322.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…der all local variable and method parameter names
@dvandersluis dvandersluis merged commit b85d786 into rubocop:master Jul 15, 2025
24 checks passed
@dvandersluis dvandersluis deleted the issue/14322 branch July 15, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discourage "it" as function parameter

2 participants