KEMBAR78
[Fix #14309] Update `Style/SoleNestedConditional` to properly correct assignments within `and` by dvandersluis · Pull Request #14369 · rubocop/rubocop · GitHub
Skip to content

Conversation

@dvandersluis
Copy link
Member

When Style/SoleNestedConditional autocorrects ifs containing and nodes, and those and nodes contain assignments, ensure that the assignments are parenthesized so that operator precedence is maintained.

Fixes #14309.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit 7f150c2 into rubocop:master Jul 17, 2025
24 checks passed
@dvandersluis dvandersluis deleted the issue/14309 branch July 17, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style/SoleNestedConditional incorrectly autofixes condition with assignment

2 participants