[Fix #14370] Fix comment duplication bug in Style/AccessorGrouping separated autocorrect
#14371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the title, this addresses the following issue:
Style/AccessorGrouping#14370The logic to prevent comments from being removed during autocorrect was introduced in the following change, so the bug likely dates back to that point:
Style/AccessorGroupingautocorrection #11063When a method call does not have parentheses, its trailing comment appears to be associated with the last argument rather than the method call itself. As a result, it is possible for the end of the comment associated with
send_node.last_argumentto appear later in the source than the end ofsend_nodeitself.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.