Fix a false positive for Lint/UselessAssignment #14377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5hun-s
changed the title
|
Can you rebase with the latest master branch? |
5hun-s
force-pushed
the
fix_false_negative_for_lint_useless_assignment
branch
from
7011783 to
7ee22fb
Compare
|
I rebased on the latest master branch and corrected my commit history. |
koic
reviewed
Jul 21, 2025
| RUBY | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Could there be false positives with case-match?
Suggested change
| end | |
| end | |
| context 'when duplicate assignments in a case-match branch inside a loop', :ruby27 do | |
| context 'while loop' do | |
| it 'does not register an offense' do | |
| expect_no_offenses(<<~RUBY) | |
| while | |
| case expr | |
| in fizz then foo += 1 | |
| in buzz then foo -= 1 | |
| end | |
| end | |
| RUBY | |
| end | |
| end | |
| end |
There was a problem hiding this comment.
You're right, it's necessary as well. I've added it. Thank you.
koic
reviewed
Jul 21, 2025
lib/rubocop/cop/variable_force.rb
Outdated
| def reference_assignments(loop_assignments, node) | ||
| # If inside a case statement, mark all as referenced. | ||
| # Otherwise, mark only the last assignment as referenced. | ||
| if loop_assignments.first.node.each_ancestor(:case).any? |
There was a problem hiding this comment.
Is it necessary to account for case-match?
Suggested change
| if loop_assignments.first.node.each_ancestor(:case).any? | |
| if loop_assignments.first.node.each_ancestor(:case, :case_match).any? |
There was a problem hiding this comment.
You're right, it's necessary as well. I've added it. Thank you.
5hun-s
force-pushed
the
fix_false_negative_for_lint_useless_assignment
branch
from
7ee22fb to
bfe8ff3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rubocop/rubocop-jp#15. (This link is Japanese issue)
This PR fixes a false positive for
Lint/UselessAssignmentwhen the assignment is inside a loop body.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.