[Fix #14413] Fix a false positive for Layout/EmptyLinesAroundArguments with multiline strings that contain only whitespace
#14422
+17
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Arguments` with multiline strings that contain only whitespace The previous implementation was doing a bunch of work to decide if a line was supposed to be considered or not. For example, Module.new with method definitions may contain newlines that should be ignored. This new implementation only considers the ranges between arguments. The old implementationseemed to have issues with array-style method calls. To be honest, I did not try to understand the original implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14413
The previous implementation was doing a bunch of work to decide if a line was supposed to be considered or not.
For example, Module.new with method definitions may contain newlines that should be ignored.
This new implementation only considers the ranges between arguments. The old implementation seemed to have issues with array-style method calls. To be honest, I did not try to understand the original implementation.
This implementation works by checking each argument (and also the closing bracket), looking to the left of it for whitespace and checking if that range goes over multiple lines.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.