[Fix #14443] Fix false positive in Layout/EmptyLinesAfterModuleInclusion
#14444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Aug 14, 2025
koic
reviewed
Aug 14, 2025
spec/rubocop/cop/layout/empty_lines_after_module_inclusion_spec.rb
Outdated
Show resolved
Hide resolved
koic
reviewed
Aug 14, 2025
…leInclusion` - Don't register an offense (and hence don't infinite loop when autocorrecting `Layout/EmptyLinesAfterModuleInclusion` and `Layout/EmptyLinesAroundBlockBody`) when the `include` send node is not followed by a constant argument. Example: ```ruby includes = [include, sdk_include].compact ``` vs. ```ruby include SdkIncludeModule ```
issyl0
force-pushed
the
fix-false-positive-module-inclusion-cop
branch
from
433a3c5 to
49c140b
Compare
|
Thanks @koic - I made those changes. |
lovro-bikic
reviewed
Aug 15, 2025
|
|
||
| def on_send(node) | ||
| return if node.receiver | ||
| return if node.receiver || !node.arguments.one? |
There was a problem hiding this comment.
include and other module inclusion methods can take more than one argument, so this change introduces false negatives.
There was a problem hiding this comment.
Thanks! Hopefully #14455 is better?
There was a problem hiding this comment.
Looks good to me, thanks!
issyl0
added a commit
to issyl0/rubocop
that referenced
this pull request
Aug 17, 2025
- The fix for `Layout/EmptyLinesAfterModuleInclusion` cop in 49c140b produced false negatives[1] when `include` and friends were, validly, called with multiple arguments. [1]: rubocop#14444 (comment)
8 tasks
issyl0
added a commit
to issyl0/rubocop
that referenced
this pull request
Aug 17, 2025
- The fix for `Layout/EmptyLinesAfterModuleInclusion` cop in 49c140b produced false negatives[1] when `include` and friends were, validly, called with multiple arguments. [1]: rubocop#14444 (comment)
issyl0
added a commit
to issyl0/rubocop
that referenced
this pull request
Aug 18, 2025
- The fix for `Layout/EmptyLinesAfterModuleInclusion` cop in 49c140b produced false negatives[1] when `include` and friends were, validly, called with multiple arguments. [1]: rubocop#14444 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layout/EmptyLinesAfterModuleInclusionandLayout/EmptyLinesAroundBlockBody) when theinclude(or others affected by this cop) send node is/are not followed by a single argument (usually a constant).Example:
vs.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.