Fix wrong autocorrect for Style/For with save navigation in the collection
#14459
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Aug 18, 2025
| extend NodePattern::Macros | ||
|
|
||
| CORRECTION = '%<collection>s.each do |%<argument>s|' | ||
| CORRECTION = '%<collection>s%<dot>seach do |%<argument>s|' # codespell:ignore |
There was a problem hiding this comment.
codespell thinks seach should be search or something similar to it
There was a problem hiding this comment.
Can you specify it in the .codespellrc file instead of using the # codespell:ignore comment annotation?
https://github.com/rubocop/rubocop/blob/master/.codespellrc
There was a problem hiding this comment.
Seemed better to me to add it inline instead of allowing it everywhere. I added it to the config instead.
…lection In such a case calling `each` is not safe without also using safe navigation. `Lint/Lint/SafeNavigationChain` would pick this up so it's not a big deal but it's also not difficult to do the correct thing directly.
Earlopain
force-pushed
the
style-for-safe-nav
branch
from
f12ba8d to
90ae867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In such a case calling
eachis not safe without also using safe navigation.Lint/Lint/SafeNavigationChainwould pick this up so it's not a big deal but it's also not difficult to do the correct thing directly.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.