KEMBAR78
[Fix #14477] Fix a false positive for `Style/SafeNavigation` by koic · Pull Request #14487 · rubocop/rubocop · GitHub
Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented Aug 28, 2025

This PR fixes a false positive for Style/SafeNavigation when using ternary expression with index access call with method chain.

Fixes #14477.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes a false positive for `Style/SafeNavigation`
when using ternary expression with index access call with method chain.

Fixes rubocop#14477.
@koic koic merged commit 1f9b258 into rubocop:master Aug 28, 2025
22 checks passed
@koic koic deleted the fix_a_false_positive_for_style_safe_navigation_cop branch August 28, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style/SafeNavigation crash on non-safenavigation code

1 participant