Fix the built-in Ruby LSP add-on not restarting when config files change #14507
+73
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
ruby-lsp-config-reload
branch
from
5c32430 to
4841ce2
Compare
Earlopain
commented
Sep 4, 2025
| RESTART_WATCHERS = %w[.rubocop.yml .rubocop_todo.yml].freeze | ||
|
|
||
| def initializer | ||
| def initialize |
There was a problem hiding this comment.
Typo. It doesn't affect anything but it took me embarrassingly long to notice this while debugging, so I fixed it.
…rubocop.yml`, `.rubocop_todo.yml`) change I did not actually verify rubocop#14506 by making changes to a todo. Since the adapter is given over to ruby-lsp, simply overwriting the instance variable doesn't do anything. I've adapted tests to check for the presence of the reload log message, and added one that actually goes through and checks config changes in detail.
Earlopain
force-pushed
the
ruby-lsp-config-reload
branch
from
4841ce2 to
1fea9da
Compare
Earlopain
commented
Sep 4, 2025
|
|
||
| before do | ||
| # Suppress Ruby LSP's add-on logging. | ||
| allow(RuboCop::LSP::Logger).to receive(:log) |
There was a problem hiding this comment.
This is inside mock console output, so not needed. Removing it allows me to assert against some other log messages in later tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not actually verify #14506 by making changes to a todo.
Since the adapter is given over to ruby-lsp, simply overwriting the instance variable doesn't do anything.
I've adapted tests to check for the presence of the reload log message, and added one that actually goes through and checks config changes in detail.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.