KEMBAR78
[Fix #14540] Fix an incorrect autocorrect for `Style/UnlessElse` by koic · Pull Request #14542 · rubocop/rubocop · GitHub
Skip to content

Conversation

@koic
Copy link
Member

@koic koic commented Sep 19, 2025

This PR fixes an incorrect autocorrect for Style/UnlessElse when using unless with then.

Fixes #14540.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_incorrect_autocorrect_for_style_unless_else branch from d59b358 to 39df61c Compare September 19, 2025 16:32
This PR fixes an incorrect autocorrect for `Style/UnlessElse`
when using `unless` with `then`.

Fixes rubocop#14540.
@koic koic force-pushed the fix_incorrect_autocorrect_for_style_unless_else branch from 39df61c to 0ce90cb Compare September 19, 2025 16:37
@koic koic merged commit ac81d93 into rubocop:master Sep 20, 2025
22 checks passed
@koic koic deleted the fix_incorrect_autocorrect_for_style_unless_else branch September 20, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style/UnlessElse and/or Style/MultilineIfThen leaves then, and wrong else then line is generated

1 participant