[Fix #14541] Fix gemspec parsing error when parser_prism is configured #14550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigured When ParserEngine is set to parser_prism in a base config file and RuboCop needs to parse a gemspec to detect the Ruby version, it was using DEFAULT_VERSION (2.7) which is incompatible with Prism that requires Ruby 3.3+. This fix ensures that when parser_prism is configured, we use Ruby 3.3 for parsing the gemspec file. The parsing version doesn't affect the detected required_ruby_version - it's only used for the parsing step.
|
Thanks for the PR, but I don't think this is the correct solution. The default that rubocop uses is 2.7, and that should not change with what parser engine is used. In the issue, the user does set 3.3 to be used but it has no effect, so there is something going wrong in config inheritance. That is what should be fixed. |
|
Sorry, I did not look closely enough. I understand now why you did it this way. Seems ok to me. |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ParserEngine is set to parser_prism in a base config file and RuboCop needs to parse a gemspec to detect the Ruby version, it was using DEFAULT_VERSION (2.7) which is incompatible with Prism that requires Ruby 3.3+.
This fix ensures that when parser_prism is configured, we use Ruby 3.3 for parsing the gemspec file. The parsing version doesn't affect the detected required_ruby_version - it's only used for the parsing step.
This fixes #14541.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.