Change Lint/ConstantOverwrittenInRescue to detect any constant assignment
#14596
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 11, 2025
| begin | ||
| something | ||
| rescue => foo.class::RESCUABLE_EXCEPTIONS | ||
| ^^ `RESCUABLE_EXCEPTIONS` is overwritten by `rescue =>`. |
There was a problem hiding this comment.
For this cop’s message, showing the entire exception class name as below would probably make the intention clearer.
Suggested change
| ^^ `RESCUABLE_EXCEPTIONS` is overwritten by `rescue =>`. | |
| ^^ `foo.class::RESCUABLE_EXCEPTIONS` is overwritten by `rescue =>`. |
…gnment Since the receiver of a constant assignment can be a method call (or a variable), I think it makes sense to remove the "const receiver" restriction.
viralpraxis
force-pushed
the
change-lint-constant-overriden-in-rescue-to-detect-any-constant-assignment
branch
from
3eec280 to
1f8ffa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the receiver of a constant assignment can be a method call (or a variable), I think it makes sense to remove the "const receiver" restriction.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.