[Fix #14605] Fix false positive for Lint/EmptyInterpolation when interpolation is inside a %W literal
#14606
+35
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Oct 17, 2025
| expect_correction(<<~RUBY) | ||
| ["", one, two] | ||
| RUBY | ||
| end |
There was a problem hiding this comment.
It looks like the same handling is needed not only for %W but also for %I.
There was a problem hiding this comment.
Good point, thank you. Updated.
koic
reviewed
Oct 17, 2025
| array_node = begin_node.each_ancestor(:array).first | ||
| return false unless array_node | ||
|
|
||
| array_node.source.start_with?('%W') |
There was a problem hiding this comment.
Considering %I as well, wouldn’t percent_literal? be more appropriate?
Suggested change
| array_node.source.start_with?('%W') | |
| array_node.percent_literal? |
There was a problem hiding this comment.
percent_literal? allows for %w and %i too but since those cannot contain dstr/dsym, it should be okay.
…when interpolation is inside a `%W` literal
dvandersluis
force-pushed
the
issue/14605
branch
from
688cdae to
bb5d1a3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpolating an empty string inside a
%Wliteral is a common way to include an empty string in the resulting array.Fixes #14605.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.