@bbatsov I'll squash these once you've had a chance to review 👍

@bbatsov Also, this single PR should close all 5 issues listed in my first commit message ;)

`If the method is called (or defined) and the arguments/parameters...

• that span more than one line, the closing parenthesis should be
  outdented by one IndentationWidth from the last argument/parameter
• that are all on one line, the closing parenthesis should be aligned
  with the opening parenthesis`

Can you provide just two basic code snippets to make sure we're on the same page about this?

Btw, before we merge this we should also update the cop documentation as well.

I think the best approach for this cop is to remove most of the logic and
let it depend on where the parameters are aligned at. I think there should
be only two rules:

Looking at the diff I don't see much logic removal. 😄

Looking at the diff I don't see much logic removal. 😄

"It's easy" - Famous Last Words 😉

There's more code, but logic itself is easier to understand IMO:

• If the arguments are on one line or there's no line break before the first argument and the rest of the arguments are lined up, then the right paren is aligned with the left paren.
• If there's a line break before the first argument, the right paren is outdented by IndentationWidth spaces.

There's no more looking up what kind of style the parameters are set at and therefore no more dependency on other cops.

I'll be happy to update the documentation. If you want to make sure we're on the same page, the easiest way to do that would be to just look at the tests, but here is the only example of code that Rubocop will change its results for:

Before

some_method(a,
)

After

some_method(a,
           )

Not only do I think this is correct, but keeping the tests passing for this one case would have required more logic that I didn't think was worth the tradeoff.

New code snippets that now work include:

          foo = some_method(
                             a
                           )

          foo = some_method(
                  a
                )

No additional configuration is required to make either of those work, they're based on allowing the parameter cops to put the parameters in the correct place and then placing the ) relative to them.

Fair enough. You'll have to rebase this, but the changes seem sound to me. Some doc updates would be appreciated.

@bbatsov requested doc updates are completed. Rebased onto master and should be ready to roll.

@bbatsov I referenced all the relevant issue numbers that this issue closes in my first commit message but didn't explicitly close them there in case you had other opinions, so if you agree, that will have to be done manually.

👍