Allow calling Rational#to_d without arguments #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change for Rational looks good 👍 |
fsateler
force-pushed
the
feature/rational-to-d
branch
2 times, most recently
from
9f666c4 to
dba4c57
Compare
|
Done! I also documented the error if the imaginary part is not zero |
Then the precision would be 0, just like with Float. Apply the same change to Complex, which had a different validation
fsateler
force-pushed
the
feature/rational-to-d
branch
from
dba4c57 to
6ecbd49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Then the precision would be 0, just like with Float.
See #276 (comment)