KEMBAR78
Make internal BigMath method a private method by tompng · Pull Request #432 · ruby/bigdecimal · GitHub
Skip to content

Make internal BigMath method a private method #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Make internal BigMath method a private method #432

merged 1 commit into from
Sep 15, 2025

Conversation

@tompng
Copy link
Member

@tompng tompng commented Sep 15, 2025

private def has no effect in BigMath module. Change it to private_class_method

module BigMath
  module_function

  # Private BigMath#foo and public BigMath.foo
  def foo; end 

  # Same as above. private has no effect
  private def foo; end

  # Private BigMath#foo and private BigMath.foo
  private_class_method def foo; end
end

@tompng tompng force-pushed the bigmath_private_method branch from 724a3fa to c49f0de Compare September 15, 2025 20:05
@tompng tompng merged commit d93b542 into ruby:master Sep 15, 2025
81 checks passed
@tompng tompng deleted the bigmath_private_method branch September 15, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tompng