-
Notifications
You must be signed in to change notification settings - Fork 85
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: ruby/rexml
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.4.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: ruby/rexml
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.4.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 16 files changed
- 1 contributor
Commits on Aug 26, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 185bdc7 - Browse repository at this point
Copy the full SHA 185bdc7View commit details
Commits on Sep 4, 2025
-
Fixed an issue with
IOSource#read_untilwhen reaching the end of a ……file (#288) Fix GH-287 ## Why? If `@source = nil` is set at the end of the file, prevent `IOSource#read_until` from raising an error. > /.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:524:in 'REXML::Parsers::BaseParser#pull_event': #<NoMethodError: undefined method 'eof?' for nil> (REXML::ParseException) > .gems/gems/rexml-3.4.2/lib/rexml/source.rb:275:in 'REXML::IOSource#read_until' https://github.com/ruby/rexml/blob/185bdc737da406ba4f9564726849ad3477858eb2/lib/rexml/source.rb#L266-L276 1. Reaching the end of a file in `IOSource#read`. 2. If the string remains in `@scanner.rest`, use `@scanner.scan_until(pattern)` to return `str`. 3. If `@source` is `nil`, an exception occurs.
Configuration menu - View commit details
-
Copy full SHA for 1531862 - Browse repository at this point
Copy the full SHA 1531862View commit details
Commits on Sep 7, 2025
-
The Zlib::GzipReader in JRuby does not behave as expected with REXML,…
… so the test is skipped (#292) ## Why? JRuby's `Zlib::GzipReader#readline` does not support arguments, so when using `Zlib::GzipReader.open`, it always returns an empty string and does not function. We will temporarily exclude `Zlib::GzipReader` from test coverage. ``` $ test/run.rb --location test/test_order.rb:49 Failure: test_more_ordering(REXMLTests::OrderTester) /Users/naitoh/ghq/github.com/naitoh/rexml/test/test_order.rb:110:in `test_more_ordering' 107: count += 1 108: } 109: => 110: assert_equal( actual.size, count ) 111: end if defined?(Zlib::GzipReader) 112: end 113: end <46> expected but was <0> ``` See: jruby/jruby#8997
Configuration menu - View commit details
-
Copy full SHA for b5b148e - Browse repository at this point
Copy the full SHA b5b148eView commit details -
Reject no root element XML as an invalid XML (#291)
## Why? GitHub: fix #289 We must reject all well-formed XMLs: https://www.w3.org/TR/2006/REC-xml11-20060816/#proc-types > Validating and non-validating processors alike MUST report violations of this specification's well-formedness constraints in the content of the [document entity](https://www.w3.org/TR/2006/REC-xml11-20060816/#dt-docent) and any other [parsed entities](https://www.w3.org/TR/2006/REC-xml11-20060816/#dt-parsedent) that they read. No root element XML is not well-formed because `document` requires one `element`: https://www.w3.org/TR/2006/REC-xml11-20060816/#sec-well-formed > [1] document ::= ( [prolog](https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-prolog) [element](https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-element) [Misc](https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-Misc)* ) - ( [Char](https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-Char)* [RestrictedChar](https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-RestrictedChar) [Char](https://www.w3.org/TR/2006/REC-xml11-20060816/#NT-Char)* )
Configuration menu - View commit details
-
Copy full SHA for 6ba286c - Browse repository at this point
Copy the full SHA 6ba286cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 822530c - Browse repository at this point
Copy the full SHA 822530cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ffe211 - Browse repository at this point
Copy the full SHA 4ffe211View commit details
Commits on Sep 10, 2025
-
Accept
REXML::Document.new("")for backward compatibility (#295)## Why? GitHub: Fix GH-296 XML without a root element is invalid XML, but to maintain backward compatibility, we will change the behavior of `REXML::Document.new("")` to be the same as `REXML::Document.new(nil)`. Reported by Joe Rafaniello. Thanks!!!
Configuration menu - View commit details
-
Copy full SHA for 37cde3f - Browse repository at this point
Copy the full SHA 37cde3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f32ea3 - Browse repository at this point
Copy the full SHA 4f32ea3View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.4.2...v3.4.4