KEMBAR78
Raise appropriate exception when failing to match start tag in DOCTYPE by naitoh · Pull Request #247 · ruby/rexml · GitHub
Skip to content

Raise appropriate exception when failing to match start tag in DOCTYPE #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2025
Merged

Raise appropriate exception when failing to match start tag in DOCTYPE #247

merged 2 commits into from
Mar 5, 2025

Conversation

@naitoh
Copy link
Contributor

@naitoh naitoh commented Mar 4, 2025 •
edited
Loading

Why?

Added exception to make the process easier to understand.

@naitoh naitoh marked this pull request as ready for review March 4, 2025 23:45
@naitoh naitoh requested a review from kou March 4, 2025 23:45
@kou kou merged commit a85203e into ruby:master Mar 5, 2025
67 checks passed
@naitoh naitoh deleted the add_exception_start_tag_in_doctype branch March 5, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou Awaiting requested review from kou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naitoh @kou