[DOC] Adjust argument unpacking docs and document **nil #12228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
requested changes
Dec 1, 2024
There was a problem hiding this comment.
This looks mostly good. There are some typos that need to be fixed, and an important semantic difference that **nil does not produce an empty hash, it is just ignored and does not add keywords (it's been optimized to avoid the allocation of an unnecessary hash).
nobu
reviewed
Dec 2, 2024
|
Thank you @jeremyevans @nobu, suggestions applied 🙏 |
jeremyevans
approved these changes
Dec 2, 2024
zverok
force-pushed
the
docs-argument-splatting
branch
from
1f80ee5 to
c4c1825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: I looked where to put the new
**nilfunctionality (as implemented in Bug #20064) and found out that the perspective of the unpacking documentation seems to be slightly off. So I adjusted that a bit and added the#to_a/#to_hashconvention, as well as the new**nil.