Launchable: Start recording test-spec results #12302
Conversation
ono-max
force-pushed
the
test-spec-launchable
branch
4 times, most recently
from
b677d9b to
26575eb
Compare
This comment has been minimized.
This comment has been minimized.
✅ All Tests passed!✖️no tests failed ✔️32115 tests passed(1 flake) |
1 similar comment
✅ All Tests passed!✖️no tests failed ✔️32115 tests passed(1 flake) |
ono-max
force-pushed
the
test-spec-launchable
branch
from
b2a37bc to
87f75a3
Compare
ono-max
force-pushed
the
test-spec-launchable
branch
from
87f75a3 to
288d65b
Compare
| @@ -0,0 +1,88 @@ | |||
| module LaunchableFormatter | |||
There was a problem hiding this comment.
FYI, it would have been good to make a PR to https://github.com/ruby/mspec or to add a MSpec maintainer as a reviewer of this PR to review this addition
| obj.init | ||
| end | ||
|
|
||
| def self.setDir(dir) |
There was a problem hiding this comment.
setDir is un-Ruby-like,
Also we should avoid class variables in MSpec (some early Ruby implementations might not support them, and they have weird semantics).
How about:
class << self
attr_accessor :dir
end| def finish | ||
| super | ||
|
|
||
| require_relative '../../../../../../tool/lib/launchable' |
There was a problem hiding this comment.
Since this is effectively specific to ruby/ruby and this file can only load in ruby/ruby (so https://github.com/ruby/mspec/blob/master/lib/mspec/runner/formatters/launchable.rb is kinda dead code except when used in CRuby) I think it would be best to have this formatter outside mspec, using this existing mechanism taking a formatter path: https://github.com/ruby/mspec/blob/0aabb3e548eb5ea6cad0125f8f46cee34542b6b7/lib/mspec/utils/options.rb#L298-L303
Also note there is already logic to extend the formatter in spec/default.mspec, maybe that could also be used.
2 participants
Uh oh!
There was an error while loading. Please reload this page.