KEMBAR78
Fix tests for fast_fallback by shioimm · Pull Request #12406 · ruby/ruby · GitHub
Skip to content

Conversation

@shioimm
Copy link
Contributor

@shioimm shioimm commented Dec 20, 2024

This change includes the following:

  • TCPSocket.new: Close resources in ensure
  • TCPSocket.new: Remove unnecessary comments
  • Socket.tcp: Make assert_separately in TestSocket more readable
  • Socket.tcp: Returning instead of exiting
  • Socket.tcp: Close resources in ensure
  • Socket.tcp: Avoid test failures on hosts that only support IPv4

@launchable-app
Copy link

launchable-app bot commented Dec 20, 2024

All Tests passed!

✖️no tests failed ✔️65638 tests passed(3 flakes)

@launchable-app
Copy link

All Tests passed!

✖️no tests failed ✔️34 tests passed(1 flake)

1 similar comment
@launchable-app
Copy link

All Tests passed!

✖️no tests failed ✔️34 tests passed(1 flake)

@shioimm shioimm marked this pull request as ready for review December 20, 2024 09:26
@shioimm shioimm merged commit b53a752 into ruby:master Dec 20, 2024
78 checks passed
@shioimm shioimm deleted the fix-tests-for-fast_fallback branch December 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant