Add Refinement#import_methods #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Provide
Refinement#import_methodsfunctionally to older versions to allow library authors to migrate to this safer way of re-using code in refinements.See https://bugs.ruby-lang.org/issues/17429
What changes did you make? (overview)
RubyNext::Core#import_methodsAPIbindingto#import_methodsand useRubyNext::Core.import_methods(see below).Is there anything you'd like reviewers to focus on?
It's hardly possible to backport the
#import_methodsmethod using pure Ruby for several reasons:Modulerefinements withinrefine do ... end—that makes it impossible to rely on adding aModule#import_methodsrefinement, we have to use our own helper method (RubyNext::Core.import_methods).There is no way to manipulate the lexical scope in Ruby. Okay, there is—we can use bindings. And the only way to create something with bindings is to evaluate source code.
So, here is how our back port works:
Sounds too complex, right? That's okay for a transpiler 🙂 But I'm open for suggestions and any kind of critics.
Checklist