KEMBAR78
Transfers -- combine same items, confirmation at save · Issue #5280 · rubyforgood/human-essentials · GitHub
Skip to content

Transfers -- combine same items, confirmation at save #5280

@cielf

Description

@cielf

Summary

When a user tries to save a transfer between storage locations, we should combine any same-item entries, and confirm the results before saving

Why?

Mitigation of user error

Details

Where is this

Log in as org_admin1@example.com
Click Inventory
Click Transfers
Click New Transfer
Fill in some information, including two items that are the same, and click save

This will currently just go through without confirmation or error.

What we want

Whenever we save a transfer, we will have a confirmation step
If there are duplicate items (even if different quantities), they will be combined (and the quantities summed) before the confirmation step

Use the new partner request as a model
(To see that, sign in as verified@example.com, then click on "Quantity", fill in the form (including duplicates), and click save)

Criteria for completion

  • change behaviour as described
  • automated tests to confirm behaviour
  • update user guide section on Transfers (docs/user_guide/bank/inventory_transfers.md) to include the confirmation step

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions