KEMBAR78
Other agency type should only be shown when "Other" chosen · Issue #5281 · rubyforgood/human-essentials · GitHub
Skip to content

Other agency type should only be shown when "Other" chosen #5281

@cielf

Description

@cielf

Summary

On the partner profile, "Other agency type" should only appear when "Other" chosen for agency type

Why

Field is meaningless unless "Other" is chosen, so why present it

Details

There are two ways to get to this information
1/ as a bank
Sign in as org_admin1@example.com
Click Parter Agencies
Click All Partners
Click on the name of a partner
Scroll down to the Partner Profile and click "Edit Partner Profile"
Click on "Agency Information".
You can see that both "Agency Type" and "Other Agency Type" show.

2/ as a partner
Sign in as verified@example.com
Click "Edit My Profile"

You can see that both "Agency Type" and "Other Agency Type" show.

"Other Agency Type" should only show when "Agency Type" is "Other"

Hint

you can use the hide by source val controller as a model (https://github.com/rubyforgood/human-essentials/blob/main/app/javascript/controllers/hide_by_source_val_controller.js), which we use in app/views/ad,om/users/new.html.erb (~ line 45)

Criteria for Completion

  • change as described
  • tests to support change
  • does not require a user guide update

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions