KEMBAR78
Refactor donations controller to use a view object · Issue #5358 · rubyforgood/human-essentials · GitHub
Skip to content

Refactor donations controller to use a view object #5358

@dorner

Description

@dorner

Currently this view has 20 instance variables, which is much too large. We should package these up into a view object and have it referenced. Some of the variables could be turned into methods rather than straight variable access. Any methods should likely be memoized.

Acceptance Criteria:

  • New view object created and used within the controller and view
  • Bonus: Move View::Inventory to the new place where the view object will live

For @dorner to do the first one of these so subsequent ones are easier.

Metadata

Metadata

Assignees

Labels

core teamGroomed but likely needs expert knowledge

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions