KEMBAR78
Kh add partner specific info fixes by awwaiid · Pull Request #5270 · rubyforgood/human-essentials · GitHub
Skip to content

Conversation

@awwaiid
Copy link
Collaborator

@awwaiid awwaiid commented Jul 6, 2025

Building off of #5075, this gets it ready to merge!

@awwaiid awwaiid marked this pull request as ready for review July 6, 2025 16:08
@awwaiid awwaiid requested a review from cielf July 6, 2025 16:08
@awwaiid
Copy link
Collaborator Author

awwaiid commented Jul 6, 2025

@dorner This is a follow-up from #5075 . I inlined the partial and added a missing block from the show view (viewing the partner from the bank perspective).

cielf
cielf previously requested changes Jul 7, 2025
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @awwaiid -- I thought we had it so that if the information was removed, the section wouldn't appear... but now I'm getting this in that case.
Screenshot 2025-07-07 at 11 03 35 AM

Also, on further thought -- I think we should say "essentials bank" instead of "bank" in that header. Yes?

@awwaiid awwaiid requested a review from cielf August 10, 2025 16:02
@cielf
Copy link
Collaborator

cielf commented Aug 12, 2025

LGTM -- should only need a glance from @dorner

@cielf cielf requested a review from dorner August 12, 2025 15:37
@dorner dorner merged commit ef51085 into main Aug 15, 2025
26 of 28 checks passed
@dorner dorner deleted the kh-add-partner-specific-info-fixes branch August 15, 2025 19:25
@github-actions
Copy link
Contributor

@awwaiid: Your PR Kh add partner specific info fixes is part of today's Human Essentials production release: 2025.08.17.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants