KEMBAR78
Allow saving on purchase form with deactivated vendor by jonny5 · Pull Request #5382 · rubyforgood/human-essentials · GitHub
Skip to content

Allow saving on purchase form with deactivated vendor #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

Allow saving on purchase form with deactivated vendor #5382

merged 3 commits into from
Sep 12, 2025

Conversation

@jonny5
Copy link
Collaborator

@jonny5 jonny5 commented Sep 12, 2025

Resolves #5377

Description

  • Fix saving on form if vendor for purchase is deactivated
  • Refactor existing tests to be clearer

How Has This Been Tested?

  • Tested manually and with a new system_spec.

@awwaiid awwaiid added this to the Ruby For Good 2025 DC milestone Sep 12, 2025
awwaiid
awwaiid approved these changes Sep 12, 2025
View reviewed changes
Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@awwaiid awwaiid merged commit 6de15f3 into rubyforgood:main Sep 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awwaiid awwaiid awwaiid approved these changes

Assignees

No one assigned

Labels

Ruby For Good 2025 DC

Projects

None yet

Milestone

Ruby For Good 2025 DC

Development

Successfully merging this pull request may close these issues.

If you have a purchase from an inactive vendor, you should still be able to edit it (that vendor should be available for the dropdown)

2 participants

@jonny5 @awwaiid