-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
A-configurationArea: cargo config files and env varsArea: cargo config files and env varsA-environment-variablesArea: environment variablesArea: environment variablesC-bugCategory: bugCategory: bugS-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Z-advanced-envNightly: advanced-envNightly: advanced-env
Description
Most configuration read through cargo uses helpers like Config::get_string which automatically read env vars, but configuration reading portions of Cargo that go through Config::get_table do not read environment variables. The return value here is a HashMap which doesn't proxy reads to an environment variable.
This affects, for example, source replacement. Source replacement is not configurable through environment variables (a bug) because of its use of get_table.
We should tackle this via one of two routes:
- First, remove
get_tableentirely. Just don't expose the ability to read a table and force all configuration reads to go throughget_stringand friends. This may or may not be uniformly possible as IIRC there's portions of Cargo that rely oniterwhich is a bit of a bummer. - Second, change
get_tableto return a wrapper rather than aHashMap. Reads of theHashMapwould "do the right thing" with environment variables. Again though it's not clear how such a wrapper would implementiteras well...
In any case, some questions to still work through here!
nmattia, gilescope, patrickod and dtolnay
Metadata
Metadata
Assignees
Labels
A-configurationArea: cargo config files and env varsArea: cargo config files and env varsA-environment-variablesArea: environment variablesArea: environment variablesC-bugCategory: bugCategory: bugS-needs-designStatus: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Status: Needs someone to work further on the design for the feature or fix. NOT YET accepted.Z-advanced-envNightly: advanced-envNightly: advanced-env