KEMBAR78
Update to literal-escaper 0.0.4 by lnicola · Pull Request #20012 · rust-lang/rust-analyzer · GitHub
Skip to content

Conversation

@lnicola
Copy link
Member

@lnicola lnicola commented Jun 16, 2025

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2025
@lnicola
Copy link
Member Author

lnicola commented Jun 16, 2025

r? @hkBst

@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2025

Failed to set assignee to hkBst: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@lnicola lnicola force-pushed the bump-literal-escaper branch from 2d4675b to 13a46ea Compare June 16, 2025 12:12
@hkBst
Copy link
Member

hkBst commented Jun 16, 2025

Thanks, @lnicola, maybe next time I'll try it myself.

There is one semantic change, that you may want to be aware of, which is that instead of only preserving the last unescape error, now all unescape errors are collected in a Vec before being copied to the enclosing error Vec.

@Veykril Veykril added this pull request to the merge queue Jun 24, 2025
Merged via the queue into rust-lang:master with commit 70cbf83 Jun 24, 2025
14 checks passed
@lnicola lnicola deleted the bump-literal-escaper branch June 30, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants