I'd love if we could support both at the same time, that is if editors (VSCode ...) were smarter to be honest, generally I do agree when someone folds a function they want to fold the function, not the signature in the vast majority of cases.

I wonder if we can either hook this in the typescript side to combine the folding ranges (probably needs heuristics which sound bad), or if we can emit the current behavior but also a full function fold and see what happens (as in how clients deal with that).

Either way +1 for having this do the expected thing by default somehow.

It would be very interesting to utilize collapsed_text (see #19659) when folding param lists! Of course, it can be implemented in the future PR.

For example, even though we have folded the entire fn, we can still display a "simplified parameter list" using collapsed_text.

have no idea why CI failed

@rustbot ready

The failing test is a flaky one(#20220) so I think this is good to go

@ChayimFriedman2 I think the requested changes have been handled. Could you resolve the request?

FWIW I don't think the request blocks merging, but I approved now.

Thanks! I'm not sure whether this was blocked or not but GitHub's UI said so 😅

Thanks!