fix: Use ROOT hygiene for args inside new format_args! expansion
#20073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Jun 23, 2025
| r#"//- minicore: todo, unimplemented, fmt_before_1_89_0 | ||
| fn f() { let a: u128 = 1; let b: u128 = todo$0!("asd") }"#, | ||
| r#"//- minicore: todo, unimplemented | ||
| fn f() { let a: u128 = 1; let b: u128 = unimplemented$0!("asd") }"#, |
There was a problem hiding this comment.
This tests was identical with the above one and I think this is the original intention
ShoyuVanilla
commented
Jun 23, 2025
| r#"//- minicore: todo, unimplemented, fmt_before_1_89_0 | ||
| fn f() { let a: u128 = 1; let b: u128 = todo$0!("asd") }"#, | ||
| r#"//- minicore: todo, unimplemented | ||
| fn f() { let a: u128 = 1; let b: u128 = unimplemented$0!() }"#, |
There was a problem hiding this comment.
Same as the above
ShoyuVanilla
changed the title
format_args! expansionformat_args! expansion
|
I think I prefer to just allocate the binding with |
ChayimFriedman2
approved these changes
Jun 23, 2025
Oh, that would be much simpler and plausible as everything is inside a block 😄 |
ShoyuVanilla
force-pushed
the
fix-fmt-args-hygiene
branch
from
cc6b4ac to
254c6ec
Compare
ShoyuVanilla
changed the title
format_args! expansionROOT hygiene for args inside new format_args! expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that this was because we don't have
super letbut it was definitely my mistake in #20056 😅