KEMBAR78
Add AsMut, Borrow and BorrowMut to minicore and famous_defs by A4-Tacks · Pull Request #20132 · rust-lang/rust-analyzer · GitHub
Skip to content

Add AsMut, Borrow and BorrowMut to minicore and famous_defs #20132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2025
Merged

Add AsMut, Borrow and BorrowMut to minicore and famous_defs #20132

merged 3 commits into from
Jul 6, 2025

Conversation

@A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Jul 1, 2025

No description provided.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2025
@A4-Tacks A4-Tacks force-pushed the asmut-borrow-minicore branch from ffc2008 to cb000ad Compare July 1, 2025 07:26
phyBrackets
phyBrackets suggested changes Jul 2, 2025
View reviewed changes
Copy link

@phyBrackets phyBrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and are there tests that verify these trait lookups work correctly?

@A4-Tacks
Copy link
Contributor Author

A4-Tacks commented Jul 2, 2025

and are there tests that verify these trait lookups work correctly?

I don't know

@A4-Tacks A4-Tacks requested a review from phyBrackets July 2, 2025 14:29
Veykril
Veykril requested changes Jul 3, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy the source definitions from the actual std library (ideally from the beta or nightly channel for minicore

@A4-Tacks A4-Tacks requested a review from Veykril July 5, 2025 14:04
@Veykril Veykril added this pull request to the merge queue Jul 6, 2025
Merged via the queue into rust-lang:master with commit 2691c11 Jul 6, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2025
@A4-Tacks A4-Tacks deleted the asmut-borrow-minicore branch July 23, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

@phyBrackets phyBrackets Awaiting requested review from phyBrackets

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@A4-Tacks @Veykril @phyBrackets @rustbot