KEMBAR78
Migrate `generate new` assist to use `SyntaxEditor` by Hmikihiro · Pull Request #20270 · rust-lang/rust-analyzer · GitHub
Skip to content

Migrate generate new assist to use SyntaxEditor #20270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Migrate generate new assist to use SyntaxEditor #20270

merged 1 commit into from
Jul 22, 2025

Conversation

@Hmikihiro
Copy link
Contributor

part of #15710 and #18285

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2025
lnicola
lnicola reviewed Jul 21, 2025
View reviewed changes
@Hmikihiro Hmikihiro force-pushed the migrate_generate_new branch from bc9a124 to fefb0bb Compare July 21, 2025 07:52
@Hmikihiro Hmikihiro closed this Jul 21, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2025
@Hmikihiro Hmikihiro reopened this Jul 21, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 21, 2025
@Hmikihiro Hmikihiro force-pushed the migrate_generate_new branch from 3fdbb8b to 9cc03e0 Compare July 21, 2025 08:22
ShoyuVanilla
ShoyuVanilla approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 22, 2025
Merged via the queue into rust-lang:master with commit 7cbc5a3 Jul 22, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 22, 2025
@Hmikihiro Hmikihiro deleted the migrate_generate_new branch July 22, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lnicola lnicola lnicola left review comments

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hmikihiro @lnicola @ShoyuVanilla @rustbot