KEMBAR78
fix(k8s): create PN alongside cluster in correct project by Codelax · Pull Request #4484 · scaleway/scaleway-cli · GitHub
Skip to content

fix(k8s): create PN alongside cluster in correct project #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(k8s): create PN alongside cluster in correct project #4484

merged 1 commit into from
Feb 4, 2025

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Feb 4, 2025

No description provided.

@Codelax Codelax added bug k8s Kubernetes Kapsule issues, bugs and feature requests labels Feb 4, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.32%. Comparing base (5bf53e0) to head (9789090).
Report is 471 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/k8s/v1/custom_cluster.go 50.00% 2 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (9789090). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (9789090)
2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4484      +/-   ##
==========================================
- Coverage   75.45%   69.32%   -6.14%     
==========================================
  Files         202      300      +98     
  Lines       44323    67779   +23456     
==========================================
+ Hits        33444    46986   +13542     
- Misses       9653    19142    +9489     
- Partials     1226     1651     +425

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Feb 4, 2025
Merged via the queue into scaleway:master with commit 7c6d626 Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yfodil yfodil yfodil approved these changes

Assignees

No one assigned

Labels

bug k8s Kubernetes Kapsule issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Codelax @codecov-commenter @yfodil @remyleone