KEMBAR78
chore: add support for usetesting, nlreturn and exptostd by remyleone · Pull Request #4499 · scaleway/scaleway-cli · GitHub
Skip to content

chore: add support for usetesting, nlreturn and exptostd #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2025
Merged

chore: add support for usetesting, nlreturn and exptostd #4499

merged 1 commit into from
Feb 10, 2025

Conversation

@remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@github-actions github-actions bot added registry Managed Container Registry issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests iot IoT issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests domain Domains issues, bugs and feature requests container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests iam IAM issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests billing Billing issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests baremetal vpcgw labels Feb 10, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.28169% with 127 lines in your changes missing coverage. Please review.

Project coverage is 69.22%. Comparing base (5bf53e0) to head (83a6b94).
Report is 486 commits behind head on master.

Files with missing lines Patch % Lines
core/testing.go 27.27% 8 Missing ⚠️
internal/args/unmarshal.go 60.00% 6 Missing ⚠️
internal/docgen/docgen.go 0.00% 6 Missing ⚠️
internal/namespaces/autocomplete/autocomplete.go 37.50% 5 Missing ⚠️
core/arg_specs.go 0.00% 4 Missing ⚠️
core/context.go 33.33% 4 Missing ⚠️
internal/args/args.go 0.00% 4 Missing ⚠️
internal/namespaces/baremetal/v1/custom_server.go 0.00% 4 Missing ⚠️
core/example.go 0.00% 3 Missing ⚠️
core/printer.go 0.00% 3 Missing ⚠️
... and 55 more

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (83a6b94). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (83a6b94)
2 1
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4499      +/-   ##
==========================================
- Coverage   75.45%   69.22%   -6.23%     
==========================================
  Files         202      300      +98     
  Lines       44323    68157   +23834     
==========================================
+ Hits        33444    47185   +13741     
- Misses       9653    19318    +9665     
- Partials     1226     1654     +428

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Feb 10, 2025
Merged via the queue into scaleway:master with commit 06c76c0 Feb 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Codelax Codelax Codelax approved these changes

@yfodil yfodil Awaiting requested review from yfodil

@jremy42 jremy42 Awaiting requested review from jremy42

@Laure-di Laure-di Awaiting requested review from Laure-di

Assignees

No one assigned

Labels

apple-silicon Apple Silicon issues, bugs and feature requests baremetal billing Billing issues, bugs and feature requests container Container issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests domain Domains issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@remyleone @codecov-commenter @Codelax