KEMBAR78
feat(vpc-gw): add edit mode for PAT rules by yfodil · Pull Request #4798 · scaleway/scaleway-cli · GitHub
Skip to content

feat(vpc-gw): add edit mode for PAT rules #4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2025
Merged

feat(vpc-gw): add edit mode for PAT rules #4798

merged 4 commits into from
Jun 12, 2025

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented Jun 11, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@yfodil yfodil self-assigned this Jun 11, 2025
@yfodil yfodil requested a review from a team as a code owner June 11, 2025 07:56
@yfodil yfodil requested a review from remyleone as a code owner June 11, 2025 08:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 54.63%. Comparing base (5bf53e0) to head (3edcea1).
Report is 670 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/vpcgw/v2/custom_pat_rule.go 0.00% 51 Missing ⚠️
internal/namespaces/vpcgw/v2/custom.go 0.00% 4 Missing ⚠️
internal/namespaces/vpcgw/v2/custom_gateway.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (3edcea1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (3edcea1)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #4798       +/-   ##
===========================================
- Coverage   75.45%   54.63%   -20.83%     
===========================================
  Files         202      316      +114     
  Lines       44323    80838    +36515     
===========================================
+ Hits        33444    44165    +10721     
- Misses       9653    35265    +25612     
- Partials     1226     1408      +182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone added this pull request to the merge queue Jun 12, 2025
Merged via the queue into scaleway:master with commit c8febba Jun 12, 2025
14 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@yfodil yfodil

Labels

enhancement vpcgw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yfodil @codecov-commenter @remyleone